Re: [ 1608715 ] New Quick-Fixes for the eclipse plug-in

 Hi Marco and Thierry,

thanks for the patch - great you're working on this topic!

I've got some questions and remarks:
1) I like the idea of declaring the quick fixes externally. However, being an advocate of good Eclipse citizenship, I'd very much prefer having an extension point that others could extend. That way, it'd be much easier for people to contribute their own quick fixes.

2) Could you please make sure all JavaDocs are correct? I spotted some class comments that had wrong classnames. Also, I'd like to ask you to remove the dashed comment lines.

3) Generally speaking, I'd like to ask you to improve javadoc a bit and provide more significant comments than just "<CODE>BugFix</CODE> is an extension to the <CODE>FindBugsFixer</CODE>."

4) While you're at it: why not streamline the class names of the quick fix classes? The existing quick fix classes are direct subclasses of FindBugsFixer and are all named XYZFixer, whereas your classes are subclasses of BugFix and are named XYZFix. Although I like either naming scheme, I suggest to adapt the Eclipse naming scheme (XYZResolution).

Regarding the functionality of the quick fixes, they seem to work pretty well. 

If you could fix these little issues, I'll happily apply the updated patch.

Thanks,
Peter

On 12/5/06, mbusarel@xxxxxx <mbusarel@xxxxxx> wrote:

Hi

Thierry Wyss and me are two students of the University of Applied Sciences in Rapperswil, Switzerland.
We are working on the Quickfixes for the FindBugs eclipse plugin and yesterday we submitted
our first patch through the patches tracker (see [ 1608715 ] New Quick-Fixes for the eclipse plug-in).

We uploaded this patch to see if our way to develope meets the requirements of FindBugs.
Therefore we would appreciate to have soon a feedback from you.

Thanks in advance.

Best regards

Marco Busarello ( mbusarel@xxxxxx)
Thierry Wyss (twyss@xxxxxx)


_______________________________________________
Findbugs-discuss mailing list
Findbugs-discuss@xxxxxxxxxxxxxxxxxx
http://mailman.cs.umd.edu/mailman/listinfo/findbugs-discuss