Re: Change DLS to be a style checker, rather than a correctness checker?

> I am leaning towards converting the DLS detector into a style detector. 
> Basically, style detectors report on
> dubious code that should be fixed, but may have only a low chance of 
> being something that manifests itself
> as misbehaving code. Which seems to fit what we are seeing with DLS.
>
> If we can find some subcategories of DLS that are very likely to be 
> errors, we can pull those out separately as
> correctness warnings.
>
> Does that seem reasonable to people?
That makes sense to me.

Alternately, I proposed some time back to factor the bug-style severity 
hierarchy.  Right now, there's a big gulf between "bug detector" and 
"bad style detector", and we've spent a fair amount of time fretting 
about the detectors on the margins.  I think that if we created a new 
category, something like "potential sloppy coding" or "questionable 
idiom", this would simplify the discussion a lot.  There are an awful 
lot of patterns that are not necessarily bugs in and of themselves, but 
frequently indicative of errors.  DLS is probably in that category, as 
was the RuntimeExceptionCapture detector I checked in a while ago.