logo       

Re: going through old patches...are these still relevant?: msg#00003

java.enhydra.xmlc

Subject: Re: going through old patches...are these still relevant?

Jacob Kjome wrote:

> Looking over patches #1 and #3...
>
> #1 is completely obsolete. The current source supports isSupported(). In
> fact, there is no place in XMLC that uses supports() anymore as far as I
> can tell.

That's cool.

> I'm not completely sure about patch #2. As far as I can tell, both XHTML
> and WML provide getElementById() since both XHTMLDocument and WMLDocument
> extend the org.w3c.dom interface which defines the getElementById()
> method. The patch is about patching the lazydom for LazyDocument to
> support getElementById(String). However, LazyDocument extends
> org.enhydra.apache.xerces.dom.DocumentImpl which, in turn, extends
> org.enhydra.apache.xerces.dom.CoreDocumentImpl which implements
> getElementById(String). However, unless the identifier has been defined,
> this will return null. Maybe that is the issue here? James, this is your
> patch. Can you comment on this? David or Richard, any comments from you
> guys?

You do realize that it's been a year since I was thinking about this,
right? That set of gears is a bit rusty. And has some spiders making a
home on it. :-)

The most recent stuff we've worked on was with HTML, and I haven't
touched XHTML or WML in a while. Frankly, I don't know that we'll ever
use WML again anyway, since the new 'WML' is XHTML Basic.

I'd need to blow the dust off one of our older applications, and try it
agaist the latest Barracuda/XMLC to see what works and what doesn't.

IIRC, getElementById() wasn't a show-stopper for us back then, it was
just that we were used to having it, when we moved from HTML to WML.
It was missing, so I just stuck it in.

I certainly haven't done anything to address David's concerns back then.
And the codebase has been restructured a bit since then, so it may not
apply at all.

If no one else wants it, I'd say leave it out for now. If/when DMS gets
back into XHTML, I'll re-visit the issue.

Take care y'all,

James Graves, CTO
Delta Mobile Software http://www.deltamobile.com


<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise