Re: going through old patches...are these still relevant?

Another update.

Looking over patches #1 and #3...

#1 is completely obsolete.  The current source supports
isSupported().  In fact, there is no place in XMLC that uses
supports() anymore as far as I can tell.

I'm not completely sure about patch #2.  As far as I can tell, both
XHTML and WML provide getElementById() since both XHTMLDocument and
WMLDocument extend the org.w3c.dom interface which defines the
getElementById() method.  The patch is about patching the lazydom
for LazyDocument to support getElementById(String).  However,
LazyDocument extends org.enhydra.apache.xerces.dom.DocumentImpl which, in
turn, extends org.enhydra.apache.xerces.dom.CoreDocumentImpl which
implements getElementById(String).  However, unless the identifier
has been defined, this will return null.  Maybe that is the issue
here?  James, this is your patch.  Can you comment on
this?  David or Richard, any comments from you guys?  

Also, I just implemented patch #2 locally.  I haven't committed it
yet because ObjectWeb's CVS seems to be down currently.  I'll try to
get it checked in tomorrow and hopefully get Diez to test it
out.


So, looks like the only things pending are patch #2, the unverified bug
report, and the diff to Xerces-1.4.4 which we might want to make sure the
changes of get into Xerces2 which would make the transition to the stock
Xerces2 possibly not so hard.

Jake

At 09:30 AM 6/11/2003 -0500, you wrote:

> A small update on 
> this....
>
> I've just committed patch #4 (with a few modifications) below. 
> Probably should look at patches 1 - 3 for XMLC-2.2 and the bug report
> that actually does have a patch workaround, but it is, apparently, not
> ideal and needs thought.
>
> Any other stuff that should be on the TODO list for an XMLC-2.2 full
> release?
>
> Jake
>
> At 01:30 PM 5/21/2003 -0500, you wrote:
>
> > I'm just looking back through the
> > archives at some patches I found that don't seem be included in
> > XMLC.  I'd like to know if there was a reason or if they were just
> > lost in the shuffle...
> >
> > 1.  Patch to provide support for isSupported()  - from James
> > Graves
> > http://xmlc.enhydra.org/project/mailingLists/xmlc/msg01391.html
> >
> > 2.  SSI Basedir option - from Diez B. Roggisch
> > http://xmlc.enhydra.org/project/mailingLists/xmlc/msg01393.html
> >
> > 3.  patch for using getElementByID() on a WML and XHTML document DOM
> > - from James Graves
> > http://xmlc.enhydra.org/project/mailingLists/xmlc/msg01632.html
> >
> > 4.  patch for supporting more dtds and new structure for storing
> > dtd's locally - from James Graves
> > http://xmlc.enhydra.org/project/mailingLists/xmlc/msg01641.html
> >
> > Richard actually seemed to accept this on in a follow-up message he sent,
> > but the patch was never applied.
> > http://xmlc.enhydra.org/project/mailingLists/xmlc/msg01696.html
> >
> >
> > Not patches, but might want to look into these...
> >
> > 1.  a test case pointing out a bug is provided.  Not sure if
> > the bug has been addressed yet.
> > http://xmlc.enhydra.org/project/mailingLists/xmlc/msg01749.html
> >
> > 2.  diff between XMLC's xerces and the official Xerces-1.4.4 - from
> > Denny Chambers
> > http://xmlc.enhydra.org/project/mailingLists/xmlc/msg01768.html
> >
> > If we got Xerces2 to incorporate relevant patches, that would make moving
> > to Xerces2 much easier.
> >
> >
> >
> > I'm sure there is other stuff, but I wanted to get this recorded in one
> > spot so we can easily reference what might need to be done.
> >
> > Jake