Re: Re[2]: Moving XMLC to ObjectWeb's SF

Hi Christian,

On Tuesday 28 January 2003 18:14, Christian Cryder wrote:
> Right. It is Barracuda specific. The problem is, Barracuda needs to support
> the notion of reusing DOMs,  which means rather than removing items from the
> DOM, we have to have a way to flag them as invisible (so that we can set
> them back to visible later). When we first did this, trying to actually
> remove nodes and then put them back in after render proved pretty
> cumbersome. So...that's the rationale (for better or worse ;-)
>
> Like you say, though, implementing this probably wouldn't hurt anyone else
> (unless someone just happened to start setting Node attributes to
> 'visdom="false"'...)

Hmmm. I've just had a look at the current XMLC source, and found this little 
bit of code in HTMLFormatter.java:

// Start Barracuda Kludge ======
// check the element to see if it contains a
// attribute "visdom".
// (org.enhydra.barracuda.core.comp.BComponent.VISIBILITY_MARKER)
// This controls DOM visibility. If this value exists and does not
// match to true, don't print this particular node.
// Note: This should be made generic, but for now...
Attr attr = DOMAccess.accessAttribute(fDocument, element, null, "visdom");
if (attr != null && !(Boolean.valueOf(attr.getValue()).booleanValue()))
  return;
// End Barracuda Kludge ======

The matching CVS comment says:

revision 1.21
date: 2002/01/17 07:58:11;  author: paul;  state: Exp;  lines: +14 -1
Added special case handling of the visdom attribute used by Barracuda.
This avoids many duplicated (and stale) classes in barracuda.jar

Looks like this is already in, then, and has been for about a year without 
anyone noticing it:-)

In the long run, I think we should take it out (it's really a kludge, IMO) and 
provide Barracuda with the means to easily implement an special formatter 
(basically, make everything public/protected that's needed to implement 
this), but that can wait until XMLC redesign time.

Bye,

Richard
-- 
Richard Kunze 

[ t]ivano Software, Bahnhofstr. 18, 63263 Neu-Isenburg
Tel.: +49 6102 80 99 07 - 0, Fax.: +49 6102 80 99 07 - 1
http://www.tivano.de, kunze@xxxxxxxxx