Subject: [cp-patches] Patch proposal: java.lang.Class - msg#00006

Previous Message by Date: click to view message preview

Re: [cp-patches] Patch proposal: gnu.java.nio.PipeImpl

Am Montag, 19. Juli 2004 22:20 schrieb Patrik Reali: > Hi! > > I propose the attached patch to move the native method "nativeInit" > out of gnu/java/nio/PipeImpl.java into > vm/reference/gnu/java/nio/VMPipeImpl.java (method "init"). The > patch also updates the jni code. (I never thought moving one single > method would change so many files!) > > Not very fancy, but with the potential to upset all the VM > maintainers with a new class.... Write a proper Changelog entry and go for it. Thanks for this work. I wanted to do it since some time. Michael

Next Message by Date: click to view message preview

FYI: java.io: Use correct lock for chained writers

Chained Readers and Writers should synchronize on the existing lock used by their inferior. In some cases we were not doing this. I'm checking in this patch to fix it. Regards Bryce 2004-07-20 Bryce McKinlay <mckinlay@xxxxxxxxxx> * java/io/BufferedWriter.java (BufferedWriter): Use existing lock of chained Writer when calling super-constructor. * java/io/FilterWriter.java (FilterWriter): Likewise. * java/io/PrintWriter.java (PrintWriter): Likewise. Index: BufferedWriter.java =================================================================== RCS file: /cvs/gcc/gcc/libjava/java/io/BufferedWriter.java,v retrieving revision 1.13 diff -u -r1.13 BufferedWriter.java --- BufferedWriter.java 20 Apr 2004 18:15:44 -0000 1.13 +++ BufferedWriter.java 20 Jul 2004 15:37:08 -0000 @@ -103,7 +103,7 @@ */ public BufferedWriter (Writer out, int size) { - super(out); + super(out.lock); this.out = out; this.buffer = new char[size]; this.count = 0; Index: FilterWriter.java =================================================================== RCS file: /cvs/gcc/gcc/libjava/java/io/FilterWriter.java,v retrieving revision 1.8 diff -u -r1.8 FilterWriter.java --- FilterWriter.java 23 Mar 2003 19:11:19 -0000 1.8 +++ FilterWriter.java 20 Jul 2004 15:37:08 -0000 @@ -72,7 +72,7 @@ */ protected FilterWriter(Writer out) { - super(out); + super(out.lock); this.out = out; } Index: PrintWriter.java =================================================================== RCS file: /cvs/gcc/gcc/libjava/java/io/PrintWriter.java,v retrieving revision 1.11 diff -u -r1.11 PrintWriter.java --- PrintWriter.java 20 May 2003 09:13:19 -0000 1.11 +++ PrintWriter.java 20 Jul 2004 15:37:09 -0000 @@ -86,7 +86,7 @@ */ public PrintWriter(Writer wr) { - super(wr); + super(wr.lock); this.out = wr; } @@ -102,7 +102,7 @@ */ public PrintWriter(Writer wr, boolean autoflush) { - super(wr); + super(wr.lock); this.out = wr; this.autoflush = autoflush; }

Previous Message by Thread: click to view message preview

[cp-patches] Patch proposal: gnu.java.nio.PipeImpl

Hi! I propose the attached patch to move the native method "nativeInit" out of gnu/java/nio/PipeImpl.java into vm/reference/gnu/java/nio/VMPipeImpl.java (method "init"). The patch also updates the jni code. (I never thought moving one single method would change so many files!) Not very fancy, but with the potential to upset all the VM maintainers with a new class.... -Patrik diff.txt Description: Text document _______________________________________________ Classpath-patches mailing list Classpath-patches@xxxxxxx http://lists.gnu.org/mailman/listinfo/classpath-patches

Next Message by Thread: click to view message preview

FYI: java.io: Use correct lock for chained writers

Chained Readers and Writers should synchronize on the existing lock used by their inferior. In some cases we were not doing this. I'm checking in this patch to fix it. Regards Bryce 2004-07-20 Bryce McKinlay <mckinlay@xxxxxxxxxx> * java/io/BufferedWriter.java (BufferedWriter): Use existing lock of chained Writer when calling super-constructor. * java/io/FilterWriter.java (FilterWriter): Likewise. * java/io/PrintWriter.java (PrintWriter): Likewise. Index: BufferedWriter.java =================================================================== RCS file: /cvs/gcc/gcc/libjava/java/io/BufferedWriter.java,v retrieving revision 1.13 diff -u -r1.13 BufferedWriter.java --- BufferedWriter.java 20 Apr 2004 18:15:44 -0000 1.13 +++ BufferedWriter.java 20 Jul 2004 15:37:08 -0000 @@ -103,7 +103,7 @@ */ public BufferedWriter (Writer out, int size) { - super(out); + super(out.lock); this.out = out; this.buffer = new char[size]; this.count = 0; Index: FilterWriter.java =================================================================== RCS file: /cvs/gcc/gcc/libjava/java/io/FilterWriter.java,v retrieving revision 1.8 diff -u -r1.8 FilterWriter.java --- FilterWriter.java 23 Mar 2003 19:11:19 -0000 1.8 +++ FilterWriter.java 20 Jul 2004 15:37:08 -0000 @@ -72,7 +72,7 @@ */ protected FilterWriter(Writer out) { - super(out); + super(out.lock); this.out = out; } Index: PrintWriter.java =================================================================== RCS file: /cvs/gcc/gcc/libjava/java/io/PrintWriter.java,v retrieving revision 1.11 diff -u -r1.11 PrintWriter.java --- PrintWriter.java 20 May 2003 09:13:19 -0000 1.11 +++ PrintWriter.java 20 Jul 2004 15:37:09 -0000 @@ -86,7 +86,7 @@ */ public PrintWriter(Writer wr) { - super(wr); + super(wr.lock); this.out = wr; } @@ -102,7 +102,7 @@ */ public PrintWriter(Writer wr, boolean autoflush) { - super(wr); + super(wr.lock); this.out = wr; this.autoflush = autoflush; }