logo       

[ checkstyle-Feature Requests-1198550 ] import ordering is not masking "sta: msg#00254

Subject: [ checkstyle-Feature Requests-1198550 ] import ordering is not masking "static"
Feature Requests item #1198550, was opened at 2005-05-09 22:19
Message generated for change (Comment added) made by c_inconnu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397081&aid=1198550&group_id=29721

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core Framework
Group: Future
Status: Open
Priority: 5
Private: No
Submitted By: Scott R Duchin (duchin)
Assigned to: Nobody/Anonymous (nobody)
Summary: import ordering is not masking "static"

Initial Comment:
It seems like the ordering of import tests are not
taking into account the key word "static".

The following lines (just an example) are warned
againstthe order:
import static com.lang.Object;
import com.lang.String;

I would think there are a few ways of looking at this:

1) that all import static lines should be first before
all other imports (my preference);

or 

2) that import static lines should just skip the word
"static" and assume proper ordering of the classes.

----------------------------------------------------------------------

Comment By: David DIDIER (c_inconnu)
Date: 2007-08-02 21:06

Message:
Logged In: YES 
user_id=1490146
Originator: NO

Hi, i got "Import Order Check: Wrong order for
'org.hamcrest.CoreMatchers.is' import." on this:

import org.apache.commons.lang.builder.ToStringBuilder;

import org.junit.Before;
import org.junit.Test;

import com.a.d.X
import com.a.d.Y

import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.sameInstance;

import static org.junit.Assert.assertThat;
import static org.junit.Assert.fail;
import static org.junit.matchers.StringContains.containsString;

But according to mstudman, it should pass... So what is the status of this
RFE ?
Thanks


----------------------------------------------------------------------

Comment By: Oleg Sukhodolsky (o_sukhodolsky)
Date: 2005-05-11 11:05

Message:
Logged In: YES 
user_id=746148

Changing type of this issue to RFE.

----------------------------------------------------------------------

Comment By: Michael Studman (mstudman)
Date: 2005-05-10 12:24

Message:
Logged In: YES 
user_id=1022106

Actually, static is not ignored. The check currently expects
that regular imports come first and static imports come
after. Order within each block of imports is as before.

I propose we keep this for the moment and make it more
configurable in 4.1.

----------------------------------------------------------------------

Comment By: Oliver Burn (oburn)
Date: 2005-05-10 07:19

Message:
Logged In: YES 
user_id=218824

suggest that just ignore the static word for now. In a 4.1
release add more functionality,

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397081&aid=1198550&group_id=29721

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/


<Prev in Thread] Current Thread [Next in Thread>