logo       

[ checkstyle-Patches-1724028 ] XSLs not counting errors correctly in fileli: msg#00209

Subject: [ checkstyle-Patches-1724028 ] XSLs not counting errors correctly in filelist
Patches item #1724028, was opened at 2007-05-23 19:57
Message generated for change (Comment added) made by oburn
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397080&aid=1724028&group_id=29721

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Fabien Banch (fabienbanch)
>Assigned to: Oliver Burn (oburn)
Summary: XSLs not counting errors correctly in filelist

Initial Comment:
There is a problem in the xsl provided with Checkstyle.
They do not count correctly the number of errors for each file in the filelist.

The lines in fault : 

<xsl:template match="checkstyle" mode="filelist">
...
  <xsl:for-each select="file[@name and generate-id(.) = 
generate-id(key('files', @name))]">
    ...
    <xsl:variable name="errorCount" select="count(error)"/>



Solution to count correctly the errors (last line replaced by these 2 lines) :

<xsl:variable name="currentName" select="@name" />
<xsl:variable name="errorCount" 
select="count(../file[@name=$currentName]/error)"/>

----------------------------------------------------------------------

Comment By: Oliver Burn (oburn)
Date: 2007-06-04 14:19

Message:
Logged In: YES 
user_id=218824
Originator: NO

Thanks for the patch. I have incorporated it into CVS and it will be 
available in the next public release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397080&aid=1724028&group_id=29721

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/


<Prev in Thread] Current Thread [Next in Thread>