Am Donnerstag, den 23.02.2006, 19:08 +0900 schrieb FUJITA Tomonori:
> From: Arne Redlich <arne.redlich@xxxxxxxxxxx>
> Subject: [Iscsitarget-devel] [PATCH] propagate IET I/O errors to initiator
> Date: Wed, 22 Feb 2006 18:26:29 +0100
>
> > This patch fixes a rather nasty behaviour (bug?): in case of I/O errors,
> > IET doesn't notify the initiator and instead lets it believe the I/O
> > operation succeeded.
>
> I think that I've mentioned this issue several times. This is one of
> the well-know issues.
Well, at least to me it was rather unknown until very recently.
> > Please note that the patch below is not extensively tested. It also
> > introduces a new struct iscsi_sense_hdr which is apparently somewhat
> > close to struct scsi_sense_hdr from <scsi/scsi_eh.h>. I'd happily
> > replace the former with the latter if you think it would be beneficial.
>
> I don't think that we will implement the complete error handling. So
> can we do this in a simple way? I've attached changes to
> send_data_rsp(). I think that you can do similar changes to
> send_scsi_rsp().
Agreed, that's also why I didn't use scsi_sense_hdr right from the
start. Admittedly, I like your idea even better.
I'm gonna rework and repost my patch based on your suggestion later on.
Arne
--
Arne Redlich
Xiranet Communications GmbH
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
|