Am Mittwoch, den 15.02.2006, 08:48 -0500 schrieb Ming Zhang:
> it looks like the patch i have before. so it will not be accepted.
>
> please check email archive and find out why my patch is not merged yet.
> the reason is parameter parsing, but i do not know exactly why (if i
> know, i will fix it and get it merged long time ago).
>
> the only people here who decide whether one patch is merged or not is
> Tomof. Arne and I are code contributor and technical support man.
>
> Ming
>
Apart from that, it still won't work with nullio. ;-)
Arne
> On Wed, 2006-02-15 at 08:54 +0100, Damian Pietras wrote:
> > On Wed, Feb 15, 2006 at 08:04:46AM +0100, Damian Pietras wrote:
> > > On Tue, Feb 14, 2006 at 11:53:09AM -0500, Ming Zhang wrote:
> > > > On Tue, 2006-02-14 at 13:54 +0100, Arne Redlich wrote:
> > > > > Am Dienstag, den 14.02.2006, 12:05 +0100 schrieb Damian Pietras:
> > > > > > This is the ReadOnly patch recently sent by Ming Zhang ported
> > > > > > to 0.4.12 (and 0.4.13). I've also added information about IOMode
> > > > > > to /proc/net/iet/volume.
> > > > > >
> > > > > > It was tested with Windows and Linux. Linux does not recognize the
> > > > > > device as write protected, this is a bug in the kernel and will be
> > > > > > fixed
> > > > > > in the next version.
> > > > > >
> > > > > Just had a glimpse at it - "IOMode" shouldn't be specific to fileio,
> > > > > it
> > > > > should rather be independent of the iotype.
> > > >
> > > > agree. but where u have this impression?
> > > >
> > > > also this patch still has that parameter parsing issue before it can be
> > > > accepted.
> > >
> > > OK, it looks silly in filo-io.c, I can move it to volume.c, but what to
> > > do with parsing? Maybe just use one function (parse_volume_args()) to
> > > parse everything?
> >
> > Or this patch would be acceptable?
> >
--
Arne Redlich
Xiranet Communications GmbH
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
|
