should be ok with that netlink patch.
ming
On Wed, 2006-01-11 at 09:36 -0800, K Chapman wrote:
> --- Arne Redlich <arne.redlich@xxxxxxxxxxx> wrote:
>
> > As previously discussed, this is a slight
> > modification of Ming's CmdSN
> > patch. It fixes {Max,Exp}CmdSN values for discovery
> > sessions and also
> > incorporates a workaround to the AIX CmdSN issue by
> > incrementing
> > MaxCmdSN by 1.
> >
> > I hope it's alright to send this as one patch, as
> > Ming's original patch
> > formatting was corrupted and the changes are small
> > enough.
> >
> > @K Chapman
> > Could you please verify that the AIX issue is fixed
> > by this patch? To do
> > so, please use svn rev. 21 and apply this one on top
> > of it. Thanks.
> >
> > Arne
> >
> > Index: usr/iscsid.c
> >
> ===================================================================
> > --- usr/iscsid.c (Revision 21)
> > +++ usr/iscsid.c (Arbeitskopie)
> > @@ -385,10 +385,9 @@
> > /* } */
> >
> > ki->param_get(conn->tid, 0, key_session,
> > conn->session_param);
> > - conn->exp_cmd_sn = be32_to_cpu(req->cmd_sn);
> > - log_debug(1, "exp_cmd_sn: %d,%d",
> > conn->exp_cmd_sn, req->cmd_sn);
> > - conn->max_cmd_sn = conn->exp_cmd_sn;
> > }
> > + conn->exp_cmd_sn = be32_to_cpu(req->cmd_sn);
> > + log_debug(1, "exp_cmd_sn: %d,%d",
> > conn->exp_cmd_sn, req->cmd_sn);
> > text_key_add(conn, "TargetPortalGroupTag", "1");
> > }
> >
> > @@ -572,6 +571,7 @@
> > rsp->sid = conn->sid;
> > rsp->stat_sn = cpu_to_be32(conn->stat_sn++);
> > rsp->exp_cmd_sn = cpu_to_be32(conn->exp_cmd_sn);
> > + conn->max_cmd_sn = conn->exp_cmd_sn + 1;
> > rsp->max_cmd_sn = cpu_to_be32(conn->max_cmd_sn);
> > return;
> > init_err:
> > @@ -658,6 +658,7 @@
> >
> > rsp->stat_sn = cpu_to_be32(conn->stat_sn++);
> > rsp->exp_cmd_sn = cpu_to_be32(conn->exp_cmd_sn);
> > + conn->max_cmd_sn = conn->exp_cmd_sn + 1;
> > rsp->max_cmd_sn = cpu_to_be32(conn->max_cmd_sn);
> > }
> >
> > @@ -676,6 +677,7 @@
> >
> > rsp->stat_sn = cpu_to_be32(conn->stat_sn++);
> > rsp->exp_cmd_sn = cpu_to_be32(conn->exp_cmd_sn);
> > + conn->max_cmd_sn = conn->exp_cmd_sn + 1;
> > rsp->max_cmd_sn = cpu_to_be32(conn->max_cmd_sn);
> > }
>
> argh... using the rev21 i get errors building. my
> issue is im using centos with 2.6.9 (i need this for
> oracle testing).
>
> event.c:102: error: too many arguments to function
> `netlink_kernel_create'
>
> --- event.c.orig 2006-01-11 12:30:06.254360735
> -0500
> +++ event.c 2006-01-11 12:30:22.115184970 -0500
> @@ -99,7 +99,7 @@
>
> int event_init(void)
> {
> - nl = netlink_kernel_create(NETLINK_IET, 1,
> event_recv, THIS_MODULE);
> + nl = netlink_kernel_create(NETLINK_IET,
> event_recv);
> if (!nl)
> return -ENOMEM;
> else
>
>
> is this patch gonna cause issues or is this ok for a
> back compat for now? ive got the other back compat
> patches in place and with this one, iet rev21 plus the
> cmdsn patch i get a complete build.
>
> ill be testing this if folks think this patch is ok
> for now
>
> aaarrrggghhh!!!!
> FreeBSD rocks
>
> __________________________________________________
> Do You Yahoo!?
> Tired of spam? Yahoo! Mail has the best spam protection around
> http://mail.yahoo.com
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
|
