From: Dmitry Yusupov <dmitry_yus@xxxxxxxxx>
Subject: Re: [Iscsitarget-devel] file data corruption?
Date: Fri, 15 Jul 2005 09:56:53 -0700
> Once BufferOffset's are in increasing order and no overlays. open-iscsi
> will work. Tough, it is missing important checking... so that is why
I don't think so.
iscsi_ctask_copy() and iscsi_data_recv() do not work if data_offset is
not page-aligned, if I understand the code correctly.
iscsi_data_recv() passes pages in an sg to iscsi_ctask_copy() in
order. iscsi_ctask_copy() resets conn->data_copied per data-in
pdu. What if the offset in the second data-in pdu is not page-aligned?
Try Junjiro's script. It enables you to see what's wrong in
open-iscsi (Thanks a lot to Junjiro).
With the script, two files (f10 and f19) needs multiple data-in
pdus. With the former, we have no data corruption since luckily
data_offset is page-aligned. The latter has the data corruption issue.
> corruption happened that silently. We must fix that checking first
> and see if it detects re-order.
The order checking is desirable, however, it is not related with this
issue at all. IET sends everything in order.
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
|
