logo       

[PATCH] ide: fix the IDEDMA_PCI dependency caused by drivers/ide/ppc/pmac.c: msg#00217

Subject: [PATCH] ide: fix the IDEDMA_PCI dependency caused by drivers/ide/ppc/pmac.c
drivers/ide/ppc/pmac.c uses symbols ide_build_sglist,
__ide_dma_off_quietly, __ide_dma_on and __ide_dma_timeout when
CONFIG_BLK_DEV_IDEDMA_PMAC is defined. The declarations for these
symbols (in ide.h) depend on CONFIG_BLK_DEV_IDEDMA_PCI. There is a
missing dependency for this in drivers/ide/Kconfig which causes
drivers/ide/ppc/pmac.c to fail to build if CONFIG_BLK_DEV_IDEDMA_PMAC
is selected but CONFIG_BLK_DEV_IDEDMA_PCI is not.

Signed-off-by: Juha-Matti Tapio <jmtapio@xxxxxxxxxxxxxxxxx>

diff -ur linux-2.6.12/drivers/ide/Kconfig b/drivers/ide/Kconfig
--- linux-2.6.12/drivers/ide/Kconfig    2005-06-22 22:33:05.000000000 +0300
+++ b/drivers/ide/Kconfig       2005-07-24 23:27:41.000000000 +0300
@@ -758,6 +758,7 @@ config BLK_DEV_IDE_PMAC_ATA100FIRST
 config BLK_DEV_IDEDMA_PMAC
        bool "PowerMac IDE DMA support"
        depends on BLK_DEV_IDE_PMAC
+       select BLK_DEV_IDEDMA_PCI
        help
          This option allows the driver for the built-in IDE controller on
          Power Macintoshes and PowerBooks to use DMA (direct memory access)

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>