logo       

Re: [PATCH] gfxterm clear_char: msg#00572

grub-devel-gnu

Subject: Re: [PATCH] gfxterm clear_char

On Tue, 2009-07-28 at 22:15 -0700, Joe Auricchio wrote:

> Eine kleine gfxterm.c cleanup

Applied with formatting changes.

> static void
> +clear_char(struct grub_colored_char *c)

Space is needed before the parenthesis.

> +{
> + c->code = ' ';

Indentation should be 2 spaces, not 4.

> for(i = 0; i < virtual_screen.columns * virtual_screen.rows; i++)
> {

This brace is no longer needed.

> Index: src/ChangeLog

It would be more convenient if the ChangeLog entry is posted inline
rather than inside the patch.

--
Regards,
Pavel Roskin


_______________________________________________
Grub-devel mailing list
Grub-devel@xxxxxxx
http://lists.gnu.org/mailman/listinfo/grub-devel

<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | Mail Home | sitemap | FAQ | advertise