Re: 2273 lines in 170 files consists of only space and tabulators

On Wed, Jun 10, 2009 at 11:04:56PM +0200, Felix Zielcke wrote:
> Am Samstag, den 06.06.2009, 21:53 -0400 schrieb Pavel Roskin:
> > On Sat, 2009-06-06 at 12:25 +0200, Felix Zielcke wrote:
> > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|wc -l
> > > 2273
> > > fz@fz:~/grub/grub2.git$ rgrep -E "^[[:blank:]]+$" *|sed -e 
> > > 's/:.*//'|uniq|wc -l
> > > 170
> > > 
> > > Anyone wants me to do 
> > > find . -type f -print0 | xargs -0 sed -i -r -e 's/^[[:blank:]]+$//'
> > > or does someone object?
> > > [:blank:] doestn't contain these ^L chars.
> > > 
> > > By the way `git diff --color' shows if you introduce such a line with
> > > red, but strangely not when you remove one.
> > 
> > Since we have linear development, it shouldn't be a problem for merging
> > patches.  Besides, "patch" can be told to ignore whitespace differences.
> > 
> > However, I would prefer that we remove all trailing whitespace, not just
> > that on empty lines.  That is, remove "^" from the sed expression.
> 
> Ok I just commited this.

Do you mean removing all whitespace?  I think you forgot to commit it.

Though, I'd prefer if we don't do this in one megacommit.  If we do it
gradually, we avoid breaking patches.  This makes work easier for branches
and for distributors (which essentially operate as a branch).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."


_______________________________________________
Grub-devel mailing list
Grub-devel@xxxxxxx
http://lists.gnu.org/mailman/listinfo/grub-devel