[Solved] Re: Boyer Moore overflow patch



Hello,

On Tue, Nov 23, 2004 at 04:20:30PM -0400, Tony Abou-Assaleh wrote:
> This particular patch looks sensible to me .. but I'm not sure how to test
> it (another way of saying that I'm too lazy to come up with a test case).

OK, I supply the test cases, and you create a patch which will add them
to the test suite, right? ;-)

The attached tar file contains three test cases:

subdir 1/ grep -f pat txt # shows a false match
subdir 2/ grep -f pat txt # misses a match
subdir fgrepbug/ grep -f pat badfile # misses a match

All these bugs work with grep, fgrep and egrep--grep is smart enough to see
that there are no meta characters in the pattern.

The last example comes from bug report
http://lists.gnu.org/archive/html/bug-gnu-utils/2003-02/msg00105.html
so we should credit Steve Summit for it, and for reporting the bug.

Example 2/ is the same as fgrepbug, but it artificially created.

I can supply more details how the bug works, if you want.

Would you be so kind to donate a patch to testsuite?

Yours,
Stepan

Attachment: grep_bm_bug.tar.gz
Description: GNU Zip compressed data

...



Privacy