Re: Boyer Moore overflow patch



It has been suggested before, and I would like to bring that up again.

When a patch is given to fix bug, can a test case be also provided to
verify that the bug actually fixed the problem?

In some cases, the bug is internal to the code and it is hard to make it
visible using an external test case. In such situations, a 'temporary'
patch that adds some print statements for the testing purposes should
prove beneficial.

This particular patch looks sensible to me .. but I'm not sure how to test
it (another way of saying that I'm too lazy to come up with a test case).

Cheers,

TAA

--------------------------------------------------
Tony Abou-Assaleh
Ph.D. Candidate, Faculty of Computer Science
Chair of the Dalhousie Student Chapter of the ACM
Dalhousie University, Halifax, NS, Canada, B3H 1W5
Fax: 902-492-1517
Email: taa@xxxxxxx
WWW: http://www.cs.dal.ca/~taa/
---------------------[THE END]--------------------


On Mon, 22 Nov 2004, Stepan Kasal wrote:

> Hello,
> some time ago I have created a patch to kwset.c, which fixes an
> overflow in the Boyer-Moore algorithm. According to our rules, I'm
> posting it here for review before I check it in.
>
> Regards,
> Stepan Kasal
>





...



Privacy