Re: coreutils-4.5.9: Compaq/DEC OSF/1 4.0, a success, and a patch for a failure

"Nelson H. F. Beebe" <beebe@xxxxxxxxxxxxx> wrote:
> The coreutils-4.5.9 on Compaq/DEC OSF/1 4.0 with gcc-2.95.3 succeeded,
> and all tests passed.
>
> However, a build with c89 failed like this:
>
>       c89 -DLIBDIR=\"/usr/local/lib\" -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.  
> -I/usr/local/include  -g -c `test -f 'mmap-stack.c' || echo
>       './'`mmap-stack.c
>       cc: Error: mmap-stack.c, line 71: In this statement, "stack" and "(-1)" 
> cannot be compared for equality or inequality. (noequality)
>         if (stack == MAP_FAILED)
>       ------^
>       make[3]: *** [mmap-stack.o] Error 1
>
> I applied this simple patch:
>
>       diff lib/mmap-stack.c.~1~ lib/mmap-stack.c
>       71c71
>       <   if (stack == MAP_FAILED)
>       ---
>       >   if (stack == (void*)MAP_FAILED)

Hi Nelson!

Thank you for the report and patch.
I've fixed that by removing the file altogether,
along with some other related changes.