Download Firefox: WindowsMac OS X
logo       
Google Custom Search
    AddThis Social Bookmark Button
-->

Re: bug in gdome_xml_n_mkref: msg#00003

Subject: Re: bug in gdome_xml_n_mkref
On Thu, 2004-05-06 at 18:47, Paolo Casarini wrote:
> The problem you have found was already found in the past and fixed in
> the gdome_xml_doc_mkref (gdome_xml_document.c, line 127) with a
> workaround.

I see, unfortunately the workaround didn't quite cover every case ;-)

> For this reason I think that its better to fix the bug using the
> gdome_xml_doc_mkref inside the gdome_xml_n_mkref also when
> n->_private != NULL.

Agreed, it's cleaner. I thereby attach a new patch based on this version
of the fix. I've just moved down the check n->_private != NULL but the
patch covers much more lines because indentation has changed a little
all over the body of the function.

If the patch seems reasonable to you I'll commit it right away.

Thanks,
--luca

Attachment: gdome2_patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part

<Prev in Thread] Current Thread [Next in Thread>