Re: [PATCH] add_buddies back to SILC

On Thu, 9 Dec 2004 16:29:02 +0100 (CET), Pekka Riikonen wrote
> I'm not sure what you 
> are asking.  I have not made in the code assumptions when the core 
> calls certain callbacks and assume that generally they can be called 
> anytime.  I guess it would be possible to make the assumption that 
> when we are connecting to server and add_buddy is called from the 
> core we are infact just populating the buddy list, and otherwise 
> not.  Are you in the process of eliminating the add_buddies 
> altoghether or what is your reason not to use it?

I re-added silcgaim_add_buddies() to both oldstatus and head.  The reason for
removing the add_buddies() callback is that it is currently only used at
signon.  The Gaim core passes a list of all your buddies to the protocol.  The
PRPL might not be ready to use this list of buddies when the core calls
add_buddies().  Or maybe the PRPL needed the list of buddies BEFORE the call
to add_buddies().  This would be different for each protocol.

For protocols that store your buddy list on the server, calling add_buddies()
at all may be unnecessary.  For protocols that must tell the server which
buddies you want to monitor, the PRPL is probably better off just reading from
the blist struct directly--it's not that much more complex.

And finally, the name "add_buddies" is a bit misleading... "set_buddies" makes
more sense to me.  I would think that "add_buddies" would be used to add
multiple buddies to your buddy list after you're already signed on.

-Mark

--
O      O  Mark Doliner
 \     |    mark@xxxxxxxxxxx
  \    |      www.kingant.net
"There needs to be a better word for weird."



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/