Re: [PATCH] add_buddies back to SILC

: > But 'init' is passed as FALSE to add_buddy_i from both 
: > silcgaim_add_buddy and the silcgaim_add_buddies in your patch... -Mark
: > 
: 
: Ok, I looked at silcgaim_add_buddies from way back when, before I 
: removed it, and it passes in TRUE, so you're right, but your patch has a 
: tiny problem.
:
Right, it should be TRUE in that case.

: The other question I have... is it possible to do 
: whatever needs to be done without silcgaim_add_buddies?  I'd like to get 
: rid of it, if possible.
: 
: It's only needed to populate the buddy list on the server when signing 
: on initially.  In the protocols that need to do this, it seems like it 
: would be much cleaner if it was just a part of the sign on process, 
: instead of the core calling the add_buddies callback.
: 
I'm not sure what you are asking.  I have not made in the code assumptions 
when the core calls certain callbacks and assume that generally they can 
be called anytime.  I guess it would be possible to make the assumption 
that when we are connecting to server and add_buddy is called from the 
core we are infact just populating the buddy list, and otherwise not.  Are 
you in the process of eliminating the add_buddies altoghether or what is 
your reason not to use it?

        Pekka
________________________________________________________________________
 Pekka Riikonen                                 priikone at silcnet.org
 Secure Internet Live Conferencing (SILC)       http://silcnet.org/


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/