Re: [PATCH] add_buddies back to SILC

On Thu, 9 Dec 2004 08:42:50 -0500, Mark Doliner wrote
> On Thu, 9 Dec 2004 10:15:57 +0100 (CET), Pekka Riikonen wrote
> > something...? : Yes, you are missing the boolean 'init' which tells 
> > the add_buddy_i whether we are at initialization phase (when gaim is 
> > launched and we populate the list) or whether we are actually adding 
> > a new buddy.  The problem it causes is that it may prompt many many 
> > times during the launch of the gaim user about unnecessary things, 
> > otoh those are not unnecessary when we are adding an entirely new buddy.
> 
> But 'init' is passed as FALSE to add_buddy_i from both 
> silcgaim_add_buddy and the silcgaim_add_buddies in your patch... -Mark
> 

Ok, I looked at silcgaim_add_buddies from way back when, before I removed it, 
and it passes in TRUE, so you're right, but your patch has a tiny problem.  The 
other question I have... is it possible to do whatever needs to be done without 
silcgaim_add_buddies?  I'd like to get rid of it, if possible.

It's only needed to populate the buddy list on the server when signing on 
initially.  In the protocols that need to do this, it seems like it would be 
much cleaner if it was just a part of the sign on process, instead of the core 
calling the add_buddies callback.

-Mark


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/