Re: [PATCH] add_buddies back to SILC

: > prompting user to accept a public key etc.  And when we are just 
: > populating the list with known buddies when initializing gaim it 
: > doesn't make sense to prompt for user. The patch puts back the 
: > add_buddies in SILC prpl.  Other alternative would to some other way 
: > detect that we are populating the buddy list.
: 
: Are you sure?  From looking at the code, I don't how the behavior could be
: different with and without add_buddies.  silcgaim_add_buddies() is just a for
: loop that calls silcgaim_add_buddy_i.  If silcgaim_add_buddies() doesn't exist
: then the core will just call silcgaim_add_buddy() for each buddy, and
: silcgaim_add_buddy() will in turn call silcgaim_add_buddy_i.  Unless I'm
: missing something...?
:
Yes, you are missing the boolean 'init' which tells the add_buddy_i 
whether we are at initialization phase (when gaim is launched and we 
populate the list) or whether we are actually adding a new buddy.  The 
problem it causes is that it may prompt many many times during the launch 
of the gaim user about unnecessary things, otoh those are not unnecessary 
when we are adding an entirely new buddy.

        Pekka
________________________________________________________________________
 Pekka Riikonen                                 priikone at silcnet.org
 Secure Internet Live Conferencing (SILC)       http://silcnet.org/


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/