Re: [PATCH] add_buddies back to SILC

On Fri, 26 Nov 2004 13:50:39 +0100 (CET), Pekka Riikonen wrote
> Hello,
> 
> At some point the add_buddies has been removed from the SILC prpl 
> and only the add_buddy is being used.  This will cause problems 
> because adding a buddy in SILC can be interactive process, like 
> prompting user to accept a public key etc.  And when we are just 
> populating the list with known buddies when initializing gaim it 
> doesn't make sense to prompt for user. The patch puts back the 
> add_buddies in SILC prpl.  Other alternative would to some other way 
> detect that we are populating the buddy list.

Are you sure?  From looking at the code, I don't how the behavior could be
different with and without add_buddies.  silcgaim_add_buddies() is just a for
loop that calls silcgaim_add_buddy_i.  If silcgaim_add_buddies() doesn't exist
then the core will just call silcgaim_add_buddy() for each buddy, and
silcgaim_add_buddy() will in turn call silcgaim_add_buddy_i.  Unless I'm
missing something...?
-Mark

--
O      O  Mark Doliner
 \     |    mark@xxxxxxxxxxx
  \    |      www.kingant.net
"There needs to be a better word for weird."



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/