Re: No way to save files of type ".jpg" (Patch included)

Fixed in cvs

regards,

s

On Wed, 2006-10-25 at 15:05 +0200, Stephane Delcroix wrote:
> this time (but in short) for the list:
> 
> I reported this as http://bugzilla.gnome.org/show_bug.cgi?id=364973 and
> will fix this very soon.
> 
> The proposed fix won't cover all the cases
> 
> best regards
> 
> stephane
> 
> 
> On Tue, 2006-10-24 at 23:23 +0200, Jens Grunert wrote:
> > Sorry,
> > 
> > i forgot to append the patch in the right format.
> > 
> > 
> > so long
> > jens
> > 
> > 
> > * Thus spake Jens Grunert (jens.grunert@xxxxxx):
> > > 
> > > Hi people,
> > > 
> > > i'm new to this list, so excuse me if this topic was handled before.
> > > 
> > > Sometimes i had problems to upload picture to picasaweb. The following 
> > > exception was thrown:
> > > 
> > > System.NotImplementedException: No way to save files of type ".jpg"
> > >   at FSpot.Filters.ResizeFilter.Convert (System.String source, 
> > > System.String dest) [0x00000] 
> > >   at FSpot.Filters.FilterSet.Convert (System.String source, System.String 
> > > dest) [0x00000] 
> > >   at FSpot.GoogleExport.Upload () [0x00000] 
> > > 
> > > 
> > > So what's the problem? The problem are files with the extension .JPG 
> > > (btw.: .jpg works).
> > > I think the problem is the Method:
> > > 
> > > public static string TempPath (string name, string extension){}
> > > 
> > > The Method handles only .jpg files! Btw: Why is the extension hardcoded?
> > > When you use the Method System.IO.Path.GetExtension() to get the 
> > > extension everything works fine.
> > > 
> > > So this Patch does the trick for me:
> > > 
> > > ---- snip ----
> > > 193c193,195
> > > <
> > > ---
> > > >
> > > >               // FIXME the input extension is not used.
> > > >               // // Get the real extension (case sensitive!)
> > > 195a198
> > > >                       string realextension = 
> > > > System.IO.Path.GetExtension (name);
> > > 197c200,201
> > > <                       string imgtemp = temp + "." + extension;
> > > ---
> > > >                       //string imgtemp = temp + "." + extension;
> > > >                       string imgtemp = temp + "." + realextension;
> > > ---- snip ----
> > > 
> > > 
> > > So long,
> > > Jens
> > > 
> > _______________________________________________
> > F-spot-list mailing list
> > F-spot-list@xxxxxxxxx
> > http://mail.gnome.org/mailman/listinfo/f-spot-list
-- 
Stephane Delcroix
stephane@xxxxxxxxxxxx