Re: reflogs generated by git-cvsimport

Jeff King <peff@xxxxxxxx> writes:

> Yeah, it probably should not munge the reflog with the CVS committer
> information. I suspect it would be as easy as the following (totally
> untested, not even syntax checked) patch:

That patch does not work because the $commit_read and
$commit_write file handles fall out of scope too early.
Those and $pid could be returned from the do {...} as
a list, but I think it's easier to remove the "do", declare
the variables above the block, and assign them in the block.

Also, there's $ENV{'TZ'}="UTC" at the beginning of the script
and it affects the reflogs too.  This is the annoying part.
The script runs numerous subprocesses and it is not clear to
me which of those need TZ=UTC and which ones should use the
original TZ:

- git config: doesn't matter?
- cvs: UTC?
- rsh: UTC?
- git rev-parse --verify: depends on whether $name looks in reflog
- git-init: doesn't matter?
- git-read-tree: doesn't matter
- git-symbolic-ref: original if this can write to reflog
- git-rev-parse --verify HEAD: doesn't matter
- git-for-each-ref: doesn't matter
- cvsps: UTC?
- git-update-index: doesn't matter
- git-write-tree: doesn't matter
- git-commit-tree: doesn't matter because GIT_COMMITTER_DATE and
  GIT_COMMITTER_DATE already specify "+0000".  (Might be nice to
  have author-specific time zones there though.)
- git-update-ref: original.  (Also, -m cvsimport could be added.)
- git-tag: doesn't matter because cvsimport never uses git tag -a.
- git update-ref: original
- git-hash-object: doesn't matter
- git repack: doesn't matter?
- git-count-objects: doesn't matter
- git-merge: original
- git checkout: doesn't matter?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html