Re: Proposed gdb patch

On Tue, May 28, 2002 at 11:57:14AM +0100, G. Helffrich wrote:
> 
> Dear GDBers -
> 
>      Here is a patch to gdb 5.1.1 that adds functionality to the gdb command
> language.  It implements the "edit" command featured in Sun's dbx, which
> invokes your favorite file editor on the active line of the program being
> debugged.  ChangeLog entry and patches follow.
> 
>                                        George
> 
> ----------
> 
> 2002-04-26  George Helffrich <george@xxxxxxxxxxxxxx>
> 
>         * cli/cli-cmds.c, defs.h, source.c, gdb.1: Add edit command.  This
>       command mimics the behavior of Sun dbx, and invokes an editor at
>       the current line number.  Editor comes from EDITOR environment
>       variable, or defaults to /bin/ex.

My bias is showing, but could you default to:
 - vi rather than ex, since fullscreen edit support is far more
prevalent than not in this decade.
 - Using $PATH, since I believe that neither BSDs nor Linuxen put
editors in /bin generally.

Oh, and again, you may want to update gdb.texinfo.  That's the current
updated documentation.

Thanks for the patch!

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer