Re: Expected compiler error on GENERIC?




Doug Rabson writes:
>
> Perhaps badaddr should take a volatile pointer argument?


I think that could cause more trouble than its worth.. This one case
was just an accident of how I laid things out.

I think there is something else wrong with badaddr, though.. We
shouldn't be doing the read if we got a fault. Eg:



Index: interrupt.c
===================================================================
RCS file: /home/ncvs/src/sys/alpha/alpha/interrupt.c,v
retrieving revision 1.64
diff -u -r1.64 interrupt.c
--- interrupt.c 11 Mar 2002 19:58:53 -0000 1.64
+++ interrupt.c 22 Mar 2002 14:04:19 -0000
@@ -300,7 +300,7 @@
/* disallow further machine checks */
mc_expected = 0;

- if (rptr) {
+ if (rptr && mc_received == 0) {
switch (size) {
case sizeof (u_int8_t):
*(volatile u_int8_t *)rptr = rcpt;


Drew

To Unsubscribe: send mail to majordomo@xxxxxxxxxxx
with "unsubscribe freebsd-alpha" in the body of the message



...



Privacy