Re: Various small changes to OpenSC

Stef Hoeben wrote:
> Hi,
>
> here 3 patches with what should be fixes/improvements in OpenSC:
>
> - acl_dupl.diff: don't add duplicate ACL entries, due to a card whose
>  accesss conditions don't map completely to OpenSC's.
>  E.g. the soon to be added SetCOS 4.4 card as a delete-file and a
>  delete-self AC that we mapped to OpenSC's SC_AC_OP_DELETE

ok

> - delete_file.diff: extend to an empty path, which indicates that the 
> current
>   file should be deleted.

if that's correct (sorry but I don't have a copy of iso7816-9
at hand right now) I've no objections

> - p15_init.diff:
>    - Add sc_pkcs15init_auth_by_fci() for authentication based on the
>       card's real ACLs instead of the ones from the profile files.

where is this function needed ? anyway I don't think it's good idea
to introduce a new function to do something another function should
already do.

>    - move the init_card() call after the code that sets the pin stuff

any reason for that ? I ask because it might be possible that driver
needs to access the card in order to get an id for the so-pin, but it
can't really access the card before it has been initialized.

>    - typo fix

btw: the typo was harmless when the new api is used and we should
really abandon the old style api in the next major release (we can't
give it up at the moment as the new api has some serious flaws)

Nils