Re: Patch for the pkcs15 cache

Hi Sirio,

ok, thx, applied.

In fact, I also removed the first check:

@@ -86,8 +86,7 @@
       } else {
               count = path->count;
               offset = path->index;
-               if (offset >= (size_t)stbuf.st_size
-                || offset + count >= (size_t)stbuf.st_size)
+               if (offset + count > (size_t)stbuf.st_size)
                       return SC_ERROR_FILE_NOT_FOUND; /* cache file 
bad? */
       }
       if (*buf == NULL) {

It should be OK, but if you'd find any problems with, let us know.

Stef

Sirio Capizzi wrote:

> I've created a patch for the pkcs15 cache. It seems that with the 
> actual code isn't possibile to read a cached file from the begin  to 
> the end. This is due to a wrong comparation (>= instead of >). It 
> would be very nice if you will add this patch to the next cvs commit. 
> Thanks
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> OpenSC-devel mailing list
> OpenSC-devel@xxxxxxxxxx
> http://www.opensc.org/cgi-bin/mailman/listinfo/opensc-devel
>