|
question about harddrv.{h,cc}: msg#00122emulators.bochs.devel
In the CVS of harddrv.{h,cc}, there are macros for making the class completely static. I realize that this has speed implications when there is only one hard drive class that needs to be instantiated. In any case, the following marcos are in mainline CVS: # define BX_HD_SMF static # define BX_HD_THIS_PTR theHardDrive-> # define BX_HD_THIS (theHardDrive) #else # define BX_HD_SMF # define BX_HD_THIS_PTR this-> # define BX_HD_THIS this-> #endif This does not appear consistent with other classes in Bochs that use this construct. Shouldn't BX_HD_THIS be defined as "this" rather than "this->"? Also, functions in harddrv.cc reference "this" directly. Shouldn't these functions use BX_HD_THIS instead? Thanks, Brian ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ |
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| Previous by Date: | Preliminary SMP fix: 00122, Zwane Mwaikambo |
|---|---|
| Next by Date: | Re: question about harddrv.{h,cc}: 00122, Brian Slechta |
| Previous by Thread: | Preliminary SMP fixi: 00122, Zwane Mwaikambo |
| Next by Thread: | Re: question about harddrv.{h,cc}: 00122, Brian Slechta |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
| News | FAQ | advertise |