Re: AZ scheduler issues

On Apr 3, 8:30 pm, "Matthew Wild" <mwi...@xxxxxxxxx> wrote:
> Hi,
>
> As I briefly mentioned in the other thread, I have been having issues
> with implementing scheduled recordings on Arizona.
>
> The scheduler is missing a QCOP method to retrieve a list of the
> current schedules. Such a method is however implemented in the
> recorder plugin (which strikes me as an odd place for it).
>
> The recorder plugin's methods though are implemented in quite an odd fashion:
>
> - The method signatures are wrong:
>    - "select(QString,QString,QString,QString,QString,QString)"   <--
> This function takes 0 parameters really
>    - "delete(QString,QString,QString,QString,QString,QString)"   <--
> This function actually takes 1 parameter
>    - "delete all"  <-- This one take 0 parameters also, but omits the
> () brackets (I don't find the space in the function name a problem,
> but I suggest that for consistency it should be removed)
>
> - The results from select() are returned in an awkward fashion also:
>    - success(QString) <--- Might not be surprising to hear that this
> doesn't return one result as it implies :)
>
> success(QString) actually returns 4 QStrings for every recording it
> passes back (ie. if there are 5 recordings, you will have 20 QStrings)
> There is no indication of how many recordings are included in the
> message. I also don't think they are separated, so it will be a
> nightmare if there was a future need to add more data about schedules.
>
> Also there is a hard-coded limit of 50 results... I'm not going to ask
> why :) (though it appears you may be able to request the next set of
> 50, and so on, at least)
>
> My proposed solution:
>
> To scheduler:
>  select(TIMEID)
>      "Please send me the list of schedules"
>
> From scheduler:
>   scheduleentry(TIMEID, id, start, duration, frequency, plugin, data)
>      Generated once for each event in the database.
>
>   success(TIMEID)
>      All schedules have been sent
>
> Also to satisfy the "Delete All" requirement:
>
>    deleteall(TIMEID, plugin)
>      Delete all events with plugin == plugin
>
> How does this sound?
>

It sounds good.  I'm currently using this as a base and extending it
even more to follow more of the full system flow.  Looking forward to
working with you and having this good stuff in AZ2.0.  I'll post an
API soon as I have it written up and we can review it to see if there
may be any other things we need to add.  We are also going to use this
interface to build a testing system for our testing team so great work
here.  Thanks

 Tom

> Matthew.