logo       

RE: Mac tabpages patch: msg#00047

editors.vim.mac

Subject: RE: Mac tabpages patch

> > > I would like to have feedback on this before I send this patch
out.
> >
> > The patch looks like version 6 (the latest version) and has a bug:
> > The menu bar doesn't work. I wanted to fix this last weekend but
> > didn't find the time. I just took a look, seems that the problem can
> > be fixed by moving the line
> > WindowRef drawer = NULL; //TODO: put into gui.h
> > into the first #ifdef FEAT_GUI_TABLINE block and by replacing the
> lines
> > if(whichWindow != gui.VimWindow)
> > return;
> > with
> > if(whichWindow == drawer)
> > return;
>
> Thanks, I'll include this change. With "if (" instead of "if(". It's
> amazing how some people can write advanced code but don't get the
> spaces
> right. :-)

With the patch that Bram sent out plus the minor modifications that
Nicolas provided to fix the menu bar, everything works just fine.

Great patch!



<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise