Re: Mac tabpages patch

Nicolas Weber wrote:

> > A few things I noticed on a quick try:
> >
> > - There are no tab pages labels, there is a new window with them.   
> >   Takes a lot of screen space.  Can't we have labels like on other
> >   systems, so that they really look like tab pages?
> 
> OS X doesn't have a good tab bar built in. See http://amnoid.de/vim/ 

"Zurgriff nicht erlaubt"...

> vimmacnotes.html . In my eyes, the drawer solution is really great  
> once you got used to it. Most apple screens have plenty of horizontal  
> space but vertical space is limited. Furthermore, the drawer can hold  
> a lot of tabs.

I still think tab page labels look nicer if you have only a few tabs.

> > - Maximizing with the green "+" button only changes the height.  Don't
> >   know if this was already so.
> 
> This was that way before. In my eyes, this is a good thing :-)

Sometimes I do like to use the full screen width and the drawer gets in
the way.  Oh well.

> > - Using ":set columns=999" doesn't fit the window to the screen size.
> >   Don't know if this was already so.
> 
> Yes

Hmm, that needs to be fixed...

> > I would like to have feedback on this before I send this patch out.
> 
> The patch looks like version 6 (the latest version) and has a bug:  
> The menu bar doesn't work. I wanted to fix this last weekend but  
> didn't find the time. I just took a look, seems that the problem can  
> be fixed by moving the line
> WindowRef drawer = NULL; //TODO: put into gui.h
> into the first #ifdef FEAT_GUI_TABLINE block and by replacing the lines
>      if(whichWindow != gui.VimWindow)
>          return;
> with
>      if(whichWindow == drawer)
>          return;

Thanks, I'll include this change.  With "if (" instead of "if(".  It's
amazing how some people can write advanced code but don't get the spaces
right. :-)

-- 
WOMAN:   Dennis, there's some lovely filth down here.  Oh -- how d'you do?
ARTHUR:  How do you do, good lady.  I am Arthur, King of the Britons.
         Who's castle is that?
WOMAN:   King of the who?
                                  The Quest for the Holy Grail (Monty Python)

 /// Bram Moolenaar -- Bram-+95IjRO79B4xsqv6Oivclw@xxxxxxxxxxxxxxxx -- 
http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\        download, build and distribute -- http://www.A-A-P.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///