Re: Mac tabpages patch

Hi Nicolas,

I tried to patch vim 7.0.218 on Panther and I had this error

Command output: patching file src/proto/gui_mac.pro
patching file src/gui.c
Hunk #1 succeeded at 1158 (offset -1 lines).
Hunk #2 succeeded at 2713 (offset -1 lines).
patching file src/gui.h
patching file src/gui_mac.c
Hunk #18 succeeded at 2344 (offset 21 lines).
Hunk #19 succeeded at 2493 (offset 15 lines).
Hunk #20 succeeded at 2886 (offset 18 lines).
Hunk #21 succeeded at 3088 (offset 18 lines).
Hunk #22 FAILED at 4961.
Hunk #23 succeeded at 5890 (offset 15 lines).
Hunk #24 succeeded at 6088 (offset 15 lines).
1 out of 24 hunks FAILED -- saving rejects to file src/gui_mac.c.rej
patching file src/feature.h

This Hunk #22 delete just some spaces after a command line. I decide
to delete this hunk and the sources compile.

The panel works great and the menu too!

Thanks Nicolas to fix this problem.

Regards,

Arnaud


On 3/15/07, Nicolas Weber <nicolasweber-Mmb7MZpHnFY@xxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> > A few things I noticed on a quick try:
> >
> > - There are no tab pages labels, there is a new window with them.
> > Takes
> >   a lot of screen space.  Can't we have labels like on other
> > systems, so
> >   that they really look like tab pages?
>
> OS X doesn't have a good tab bar built in. See http://amnoid.de/vim/
> vimmacnotes.html . In my eyes, the drawer solution is really great
> once you got used to it. Most apple screens have plenty of horizontal
> space but vertical space is limited. Furthermore, the drawer can hold
> a lot of tabs.
>
> > - Maximizing with the green "+" button only changes the height.  Don't
> >   know if this was already so.
>
> This was that way before. In my eyes, this is a good thing :-)
>
> > - Using ":set columns=999" doesn't fit the window to the screen size.
> >   Don't know if this was already so.
>
> Yes
>
> > I would like to have feedback on this before I send this patch out.
>
> The patch looks like version 6 (the latest version) and has a bug:
> The menu bar doesn't work. I wanted to fix this last weekend but
> didn't find the time. I just took a look, seems that the problem can
> be fixed by moving the line
> WindowRef drawer = NULL; //TODO: put into gui.h
> into the first #ifdef FEAT_GUI_TABLINE block and by replacing the lines
>      if(whichWindow != gui.VimWindow)
>          return;
> with
>      if(whichWindow == drawer)
>          return;
>
> Wait a minute, I'll attach a patch with this change included...it is
> attached (it's your patch with the change described in this mail). It
> fixes the problem fixed by v5 but the menu is still working (unlike
> as in v6). So everybody, please see if you can find any problems with
> this version.
>
> Bye,
> Nico
>
> ps: The attachment is going to be stripped, so I'll upload it to
> wiki.macvim.org as well