Re: Mac tabpages patch

I really like Nicolas' implementation on using drawer for tabs. Not
sure if it will be that usuable by people also making use of i.e.
'project.vim' plugin, which requires it's horizontal space, or
'taglist.vim' etc.

As I've also stated before, having the green button maximize, is not
the same thing as on other platforms, but that's the way apple defines
its usage.

(sorry if I'm hijacking the topic, but since Bram brought it up.) My
idea of a apple-ish way of things would, to have it maximize in
horizontal space as to fit the text on one line, without folding, and
do the same for vertical space too.

let's say we open a file,

it will look like this:
http://panos.solhost.org/temp/picture-1.tiff

the text if being folded, and we can't see the total height of the
text. So, we hit the 'green' button, to maximize. What happens (in two
steps), is this:

http://panos.solhost.org/temp/picture-2.tiff
the width (columns), expands, as much as needed, so that lines, don't
need to fold.

and also:
http://panos.solhost.org/temp/picture-3.tiff
the height (lines), expands, as much as needed, so that we can see as
much of the text, as possible. In this particular example, we still
have text beyond that point, so the window expands to the height page.

IMO this is the way to do it, if we it to be the apple IG.


If this is too much, I'd just like it to fill my whole screen. I find
the current way of things un-intuitive, 'cause I always find myself
dragging the window, to fill the width, and then hit maximize to fill
the height.


On 3/16/07, Nicolas Weber <nicolasweber-Mmb7MZpHnFY@xxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> > A few things I noticed on a quick try:
> >
> > - There are no tab pages labels, there is a new window with them.
> > Takes
> >   a lot of screen space.  Can't we have labels like on other
> > systems, so
> >   that they really look like tab pages?
>
> OS X doesn't have a good tab bar built in. See http://amnoid.de/vim/
> vimmacnotes.html . In my eyes, the drawer solution is really great
> once you got used to it. Most apple screens have plenty of horizontal
> space but vertical space is limited. Furthermore, the drawer can hold
> a lot of tabs.
>
> > - Maximizing with the green "+" button only changes the height.  Don't
> >   know if this was already so.
>
> This was that way before. In my eyes, this is a good thing :-)
>
> > - Using ":set columns=999" doesn't fit the window to the screen size.
> >   Don't know if this was already so.
>
> Yes
>
> > I would like to have feedback on this before I send this patch out.
>
> The patch looks like version 6 (the latest version) and has a bug:
> The menu bar doesn't work. I wanted to fix this last weekend but
> didn't find the time. I just took a look, seems that the problem can
> be fixed by moving the line
> WindowRef drawer = NULL; //TODO: put into gui.h
> into the first #ifdef FEAT_GUI_TABLINE block and by replacing the lines
>      if(whichWindow != gui.VimWindow)
>          return;
> with
>      if(whichWindow == drawer)
>          return;
>
> Wait a minute, I'll attach a patch with this change included...it is
> attached (it's your patch with the change described in this mail). It
> fixes the problem fixed by v5 but the menu is still working (unlike
> as in v6). So everybody, please see if you can find any problems with
> this version.
>
> Bye,
> Nico
>
> ps: The attachment is going to be stripped, so I'll upload it to
> wiki.macvim.org as well


--
Panos Laganakos