Re: Mac tabpages patch

Hi,

> A few things I noticed on a quick try:
>
> - There are no tab pages labels, there is a new window with them.   
> Takes
>   a lot of screen space.  Can't we have labels like on other  
> systems, so
>   that they really look like tab pages?

OS X doesn't have a good tab bar built in. See http://amnoid.de/vim/ 
vimmacnotes.html . In my eyes, the drawer solution is really great  
once you got used to it. Most apple screens have plenty of horizontal  
space but vertical space is limited. Furthermore, the drawer can hold  
a lot of tabs.

> - Maximizing with the green "+" button only changes the height.  Don't
>   know if this was already so.

This was that way before. In my eyes, this is a good thing :-)

> - Using ":set columns=999" doesn't fit the window to the screen size.
>   Don't know if this was already so.

Yes

> I would like to have feedback on this before I send this patch out.

The patch looks like version 6 (the latest version) and has a bug:  
The menu bar doesn't work. I wanted to fix this last weekend but  
didn't find the time. I just took a look, seems that the problem can  
be fixed by moving the line
WindowRef drawer = NULL; //TODO: put into gui.h
into the first #ifdef FEAT_GUI_TABLINE block and by replacing the lines
    if(whichWindow != gui.VimWindow)
        return;
with
    if(whichWindow == drawer)
        return;

Wait a minute, I'll attach a patch with this change included...it is  
attached (it's your patch with the change described in this mail). It  
fixes the problem fixed by v5 but the menu is still working (unlike  
as in v6). So everybody, please see if you can find any problems with  
this version.

Bye,
Nico

ps: The attachment is going to be stripped, so I'll upload it to  
wiki.macvim.org as well