Hello, Jonathan!
Sorry for a long delay. I had to release 0.15, and then I was on
vacation.
On Mon, 2006-08-28 at 11:33 -0400, Jonathan Bastien-Filiatrault wrote:
> Hi Pavel,
>
> The updated version of the patch is at
> http://x2a.org/pub/prog/orinoco-radiotap.patch . I have removed the
> get/set_radiotap, I hope that is what you wanted.
I think it's some misunderstanding. What I said is that we don't want
to have a driver that has the radiotap support disabled at the compile
time. And you were asking about the compile time (you even mentioned
ifdef).
get/set_radiotap obviously refers to the run-time configuration. That
wasn't mentioned in the earlier discussion. I think it may be useful to
be able to disable radiotap headers for legacy applications, such as
Airsnort.
> The patch is against the latest trunk.
It still applies, but it causes massive warnings on "make check".
Apparently you didn't get the endianess right. For instance, it_len is
declared u16 in net/ieee80211_radiotap.h, but your code assigns a little
endian value to it, even on big engian systems.
I tried the patched driver with Wireshark 0.99.3a. The channel and the
channel flags are clearly wrong. Have you actually tested your patch
with any software?
Speaking of the channel, I think maybe it shouldn't be filled at all if
we cannot determine it reliably? priv->channel is the channel the card
listening to. The sniffer probably wants the channel used for
transmission, either measured or stated by the transmitter. It's quite
possible to get packets from neighboring channels.
Also, I would prefer that you submit the part of your patch that
introduces LEVEL_BIAS separately. It's quite independent from the rest.
--
Regards,
Pavel Roskin
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
|
| 
