On Mon, Oct 25, 2004 at 08:03:53PM -0400, Pavel Roskin wrote:
> Hello!
>
> I have committed the changes to eliminate all warnings in readw() and
> writew() when compiling against latest kernels. It's a cheap workaround,
> just a cast to void pointer for the address argument. Transition to
> ioread16()/iowrite16() would likely take place after 0.15 release.
Yeah... I'm not sure I like this approach. I think it might be better
to make the iobase variable an (void __iomem *), and cast back to an
integer for the inb()/outb(), until we do switch over to
ioread/iowrite.
Actually, better still would be to have separate mem (pointer) and io
(integer) fields in hermes_t, since we already have the if statement
which can pick up the appropriate one.
We could use a union, but it's only 4 bytes, so who cares.
> Also, pci_save_state() and pci_restore_state() take one argument in Linux
> 2.6.10-rc1 rather than two. This has been fixed as well.
>
> The driver should support Linux 2.4.x starting with 2.4.10 and 2.6.x
> except 2.6.9-bk series (now obsoleted by 2.6.10-rc1).
Nice.
Oh, btw Pavel, you might want to look at the last few days archives of
netdev-VZNHf3L845pBDgjK7y7TUQ@xxxxxxxxxxxxxxxx, if you can find them. Another
merge-to-mainline
attempt went up.
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
|
