Re: ODBC SQLExecute succeeds when it shouldn't

On Tue, 25 Nov 2003, <nj-freetds@xxxxxxxxxx> wrote:
> I'm using a nightly snapshot of FreeTDS (20031125) with unixODBC and the
> Ruby ODBC bindings. It was working well... actually, a little TOO well.
> Queries that should raise errors weren't, for instance:
...
> After much looking at Ruby/ODBC trace statements and TDSDUMP logs, I
> made the following small patch:
...
>                 case TDS_DONEINPROC_RESULT:
> +                        if(done_flags & TDS_DONE_ERROR)
> +                               result = SQL_ERROR;
...
> See that TODO there? I was hitting an error that showed up in
> DONEINPROC, and thus _SQLExecute was returning a SQL_SUCCESS_WITH_INFO
> instead of a SQL_ERROR. 

Freddy: I applied this patch, so it didn't get lost.  It looks right to
me, but if you don't like it, just back it out.  

Thanks, Nathaniel!  I know tracking down which two lines need adding is
much harder than adding them.  

--jkl