RE: patch 20031120

> From: ZIGLIO Frediano [mailto:Frediano.Ziglio@xxxxxxxxxxxx]
> Sent: November 21, 2003 5:24 AM
> 
> > This might turn out to be the best answer.  In effect, 
> > TDSICONV would hold an "error mask" of messages to suppress.  
> > tds_iconv() would add to the mask as messages accumulated.  
> > The problem would be to remember to clear the mask when done.  
> > 
> > tds_iconv.h:
> >     struct _suppress {
> >             unsigned int ei2big:1;
> >             unsigned int eilseq:1;
> >             unsigned int einval:1;
> >     } suppress;
> >     /* ... */
> > 
> > /* caller: */
> >     memset(&iconv_info->suppress, 0, sizeof(iconv_info->suppress));
> >     iconv_info->suppress.eilseq = *wire_size > 0;
> >     irreverisible = tds_iconv(...);
> > 
> > > So you can also reset iconv state (iconv(cd, NULL,
> > > NULL, NULL, NULL) )... Does this sound reasonable ?
> > 
> > I don't know if this is important.  It might be just as easy to call
> > iconv(3) instead.  
> > 
> 
> I'd prefer a tds_iconv_reset... 

Instead of "iconv(cd, NULL, NULL, NULL, NULL)"?  OK. 

> I don't understand "iconv_info->suppress.eilseq = *wire_size > 0;"
> reason...

The only time to suppress EILSEQ is during chunking.  Look at
tds_get_char_data().  If *wire_size > 0 when we're about to call
tds_iconv(), that means we're not on the last chunk.  Unless we're on the
last chunk, we don't care about EILSEQ.  

> Perhaps the best solution should be a tds_iconv_done called 
> after every
> conversion. So to reset state for next conversion, issue
> EINVAL/EILSEQ/whatever warnings/errors and prepare everything else for
> conversion. 

I don't see a need for tds_iconv_done().  One memset(3) before calling
tds_iconv() is generally enough.  The caller will need to ensure the
_suppress structure is correct prior to calling tds_iconv(), so it won't
matter if the previous caller cleaned up _suppress or not.  

--jkl
-----------------------------------------
The information contained in this transmission may contain privileged and 
confidential information and is intended only for the use of the person(s) 
named above. If you are not the intended recipient, or an employee or agent 
responsible for delivering this message to the intended recipient, any review, 
dissemination, distribution or duplication of this communication is strictly 
prohibited. If you are not the intended recipient, please contact the sender 
immediately by reply e-mail and destroy all copies of the original message. 
Please note that we do not accept account orders and/or instructions by e-mail, 
and therefore will not be responsible for carrying out such orders and/or 
instructions.