RE: patch 20031120

> From: ZIGLIO Frediano [mailto:Frediano.Ziglio@xxxxxxxxxxxx]
> Sent: November 20, 2003 8:55 AM
> 
> However I changed tds_iconv prototype and some behaviour. io parameter
> was replaced with a flags parameter that specify direction, previous
> error and chunking behaviour. tds_iconv return a set of 
> errors, not only
> a single error.
> Onestly I don't like that much the change (perhaps it's best to add a
> int* flags parameter??)... however it works.

Ugh, I don't like it either.  I'll review your mail in case you told me
already, but I don't understand why tds_iconv should care about incomplete
end-of-buffer sequences.  It should return normally, leaving errno set to
EILSEQ, and let the caller determine if that's an error warranting a user
message or not.  

Please, let's not overload TDS_ICONV_DIRECTION.  We can bury a flag in
TDSSOCKET or TDSICONVINFO if need be.  

--jkl
-----------------------------------------
The information contained in this transmission may contain privileged and 
confidential information and is intended only for the use of the person(s) 
named above. If you are not the intended recipient, or an employee or agent 
responsible for delivering this message to the intended recipient, any review, 
dissemination, distribution or duplication of this communication is strictly 
prohibited. If you are not the intended recipient, please contact the sender 
immediately by reply e-mail and destroy all copies of the original message. 
Please note that we do not accept account orders and/or instructions by e-mail, 
and therefore will not be responsible for carrying out such orders and/or 
instructions.