RE: Bill's patch submitted

Hey Freddy,

the rpc_ct_param fault is solved by the following: The TODO can maybe now be
removed :-)

...I now check if the column is hidden or not in ct_res_info....

tds_get_data_info(TDSSOCKET * tds, TDSCOLINFO * curcol)
{

    curcol->column_namelen = tds_get_string(tds, tds_get_byte(tds),
curcol->column_name, sizeof(curcol->column_name) - 1);
    curcol->column_name[curcol->column_namelen] = '\0';

    curcol->column_flags = tds_get_byte(tds);   /*  Flags */

    /* TODO check if all flags are the same for all TDS versions */
+  if (IS_TDS50(tds))
+      curcol->column_hidden = curcol->column_flags & 0x1;
-   curcol->column_hidden = curcol->column_flags & 0x1;
    curcol->column_key = (curcol->column_flags & 0x2) > 1;
    curcol->column_writeable = (curcol->column_flags & 0x10) > 1;


Bill

> -----Original Message-----
> From: ZIGLIO Frediano [SMTP:Frediano.Ziglio@xxxxxxxxxxxx]
> Sent: 31 October 2003 14:29
> To:   FreeTDS Development Group
> Subject:      RE: [freetds] Bill's patch submitted
> 
> ...
> > 
> > > - why you not send data (tds_flush_packet) within some tds_cursor_* 
> > > functions ? You should also test result of tds_flush_packet
> > 
> > because in ct-library you can batch up a declare cursor, 
> > cursor setrows and cursor open into one send
> > 
> 
> IMHO is better to separate even TDS_IDLE -> TDS_QUERYING from sending
> partial packet. Perhaps another state (TDS_PARTIALQUERYING) ??
> 
> ...
> 
> bye
>   freddy77
> _______________________________________________
> FreeTDS mailing list
> FreeTDS@xxxxxxxxxxxxxxxxx
> http://lists.ibiblio.org/mailman/listinfo/freetds