Re: patch to allow extra perl args on #! lines

2006-12-05T17:16:53 Lupe Christoph:
> That's what we mean with not portable. You missed that FreeBSD was
> not doing that either until 6.mumble.

I did. I guess the scope of this non-portability is bigger than I
thought. I take it adding an obscure feature to the munin distro
that only works on some but not all platforms isn't gonna happen?

That's certainly fair.

> So you require this for testing? Production uses site_perl? I would
> recommend you use a wrapper at some other location that calls perl
> -I<temp_path> $*.

We require this for production use. We don't insist that you deliver
it for us, by any means:-); while it'd remove a really negligible
bit of customizing if this patch were accepted upstream, applying it
locally when we need to upgrade isn't painful at all. So if it's
distasteful and nobody else has any use for it, I quite understand.

> You will have to change all Perl programs for installation anyway.

Sure do. Any perl program that depends on modules outside the perl
core distro ends up having to be modified when we install it.

> Please understand that we are reluctant to add a feature that until now
> nobody has requested, and that you only require for testing.

I fully understand. The first half is very convincing. "only require
for testing" I'm afraid is not the case for us, though.

> Especially when we know that it breaks on some platforms.

True enough, although in mitigation I'd say that it doesn't break
anything else; those platforms just can't benefit from the feature
(the extra args that can't be specified with the current distro just
won't show up).

> And when there are easier solutions available.

I'm not 100% perfectly clear on what that easier solution would be,
could you please help me out? If you're referring to the above
"recommend you use a wrapper that calls perl -I/prod/path $*", how
would that work? #! magic shells can't themselves be #! magic. I
guess we could do it with a wrapper in C, but I think I'd prefer to
maintain our patch in-house rather than maintain an opaque binary
wrapper executable.

> > Just from ogling the patch, munin-node.in and munin-run.in have -wT.
> 
> It would be a good idea to turn on warnings (-w) in all Perl programs.

From ogling that patch it looks like you've got over half of 'em.

I use -w on all my own perl, but there's a vocal group, with Damian
Conway prominent among 'em, that advice "use warnings" instead.

-Bennett

pgpMyEF08ktSt.pgp
Description: PGP signature

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV_______________________________________________
munin-users mailing list
munin-users@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/munin-users