Re: ODBC int2 parameters to pg function

Tom,
Thanks for the reply.

I agree with your solution in principle, but I have nearly 100 databases 
so far across several servers and many at customer sites. I am trying to 
migrate some from and maintain compatibility with MS SQLServer. 
These quantities have been smallint for quite some time. Changing the 
underlying database types now would be a problem.

I can cast inside the function, this is my current solution. Given that 
there is no implicit downcast wouldn't the best solution be to get the 
ODBC driver do the cast on the function call?

Thanks,
Gary.

On 13 Mar 2004 at 19:40, Tom Lane wrote:

> Gary Doades <gpd@xxxxxxxxx> writes:
> > I have delcared a pg function as:
> > function GENERATE_TIMESHEETS(timestamp,timestamp,smallint,smallint)
> > ....
> 
> You're probably best off to declare the inputs as integer not smallint.
> Integer literals are assumed to be int4 by default, and since there's
> no implicit downcast to int2 (anymore), writing a function this way will
> require you to cast to smallint explicitly a lot.  It's seldom worth
> that notational hassle.  You can cast inside the function if you really
> need the values to be int2 inside it.
> 
>                       regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings



---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

               http://www.postgresql.org/docs/faqs/FAQ.html