Tom Lane wrote:
Looks right to me; but as a general tip, if you've made mistake X in
place A, you might have made it in place B too. Have you checked the
rest of dblink for forgotten SPI_finish calls?
That function was the only one using SPI calls in dblink, so there were
no others. Fix applied to head, 7.3 stable, and 7.4 stable.
(More generally, I wonder if AtEOXact_SPI oughtn't be fixed to emit
a WARNING if the SPI stack isn't empty, except in the error case.
Neglecting SPI_finish is analogous to a resource leak, and we have
code in place to warn about other sorts of leaks.)
I'll look at this separately. Changes in this regard only belong applied
to cvs head I assume.
Joe
---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to majordomo@xxxxxxxxxxxxxx so that your
message can get through to the mailing list cleanly
|
Try Searching:
servers, voip, java, networking, microsoft ...
|
|
|
| 
