logo       

Re: [HACKERS] ALTER TABLE ... ADD COLUMN: msg#00165

Subject: Re: [HACKERS] ALTER TABLE ... ADD COLUMN
Alvaro, I am seeing the attached regression failure, which I assume was
caused by your patch.  Is the new regression output correct, or is there
something wrong?

---------------------------------------------------------------------------

pgman wrote:
> 
> Patch applied.  Thanks.
> 
> ---------------------------------------------------------------------------
> 
> 
> Alvaro Herrera wrote:
> > En Fri, 4 Oct 2002 18:21:06 -0400
> > Alvaro Herrera <alvherre@xxxxxxxxxxx> escribi?:
> > 
> > > Huh, I don't know where I got the idea you were (or someone else was?)
> > > in the position that attislocal should be reset.  I'll clean everything
> > > up and submit the patch I had originally made.
> > 
> > All right, this is it.  This patch merely checks if child tables have
> > the column.  If atttypid and atttypmod are the same, the attributes'
> > attinhcount is incremented; else the operation is aborted.  If child
> > tables don't have the column, recursively add it.
> > 
> > attislocal is not touched in any case.
> > 
> > -- 
> > Alvaro Herrera (<alvherre[a]atentus.com>)
> > "El Maquinismo fue proscrito so pena de cosquilleo hasta la muerte"
> > (Ijon Tichy en Viajes, Stanislaw Lem)
> 
> [ Attachment, skipping... ]
> 
> > 
> > ---------------------------(end of broadcast)---------------------------
> > TIP 6: Have you searched our list archives?
> > 
> > http://archives.postgresql.org
> 
> -- 
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@xxxxxxxxxxxxxxxx               |  (610) 359-1001
>   +  If your life is a hard drive,     |  13 Roberts Road
>   +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@xxxxxxxxxxxxxxxx               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
*** ./expected/misc.out Fri Oct 18 22:34:51 2002
--- ./results/misc.out  Fri Oct 18 22:38:03 2002
***************
*** 377,436 ****
  --   SET a = text 'gazpacho'
  --   WHERE aa > 4;
  SELECT class, aa, a FROM a_star*;
!  class | aa | a 
! -------+----+---
!  a     |  1 | 
!  a     |  2 | 
!  a     |    | 
!  b     |  3 | 
!  b     |  4 | 
!  b     |    | 
!  b     |    | 
!  c     |  5 | 
!  c     |  6 | 
!  c     |    | 
!  c     |    | 
!  d     |  7 | 
!  d     |  8 | 
!  d     |  9 | 
!  d     | 10 | 
!  d     |    | 
!  d     | 11 | 
!  d     | 12 | 
!  d     | 13 | 
!  d     |    | 
!  d     |    | 
!  d     |    | 
!  d     | 14 | 
!  d     |    | 
!  d     |    | 
!  d     |    | 
!  d     |    | 
!  e     | 15 | 
!  e     | 16 | 
!  e     | 17 | 
!  e     |    | 
!  e     | 18 | 
!  e     |    | 
!  e     |    | 
!  f     | 19 | 
!  f     | 20 | 
!  f     | 21 | 
!  f     | 22 | 
!  f     |    | 
!  f     | 24 | 
!  f     | 25 | 
!  f     | 26 | 
!  f     |    | 
!  f     |    | 
!  f     |    | 
!  f     | 27 | 
!  f     |    | 
!  f     |    | 
!  f     |    | 
!  f     |    | 
! (50 rows)
! 
  --
  -- versions
  --
--- 377,383 ----
  --   SET a = text 'gazpacho'
  --   WHERE aa > 4;
  SELECT class, aa, a FROM a_star*;
! ERROR:  Relation "d_star" has no column "a"
  --
  -- versions
  --

======================================================================

---------------------------(end of broadcast)---------------------------
TIP 5: Have you checked our extensive FAQ?

http://www.postgresql.org/users-lounge/docs/faq.html
<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

Recently Viewed:
linux.arklinux....    user-groups.lin...    kde.usability/2...    ietf.ipp/2002-0...    mail.spam.spamc...    os.netbsd.devel...    audio.cd-record...    text.unicode.de...    php.documentati...    games.fps.halfl...    window-managers...    suse.oracle.gen...    bug-tracking.gn...    video.dvdrip.us...    xfree86.cvs/200...    java.netbeans.m...    network.argus/2...    culture.sf.kill...    debian.ports.al...    freebsd.questio...    qplus.devel/200...    handhelds.palm....   
Home | blog view | USPTO Patent Archive | advertise | OSDir is an inevitable website. super tiny logo

Free Magazines

Cisco News
Receive a free quarterly e-newsletter with exclusive articles on how Cisco IT uses its own products and solutions to enable the business.
subscribe

Systems Management News, the newspaper for IT systems administration and data center managers! Each issue of Systems Management News is chock-full of news and analysis to help you understand what's happening in your field.
subscribe

The Enterprise Newsweekly eWeek is the essential technology information source for builders of e-business.
subscribe

Oracle Magazine Oracle Magazine contains technology strategy articles, sample code, tips, Oracle and partner news, how to articles for developers and DBAs, and more. Oracle (NASDAQ: ORCL) is the world's largest enterprise software company.
subscribe

Total Telecom Total Telecom is "The Economist of the communications industry".
subscribe