logo       

Raid crash with 4.0: msg#00442

db.mysql.devel

Subject: Raid crash with 4.0

Hi,

Perhaps a simple fix would be to change :


assert(pos != MY_FILEPOS_ERROR);

if (is_raid(fd))
{
RaidFd *raid= (*dynamic_element(&RaidFd::_raid_map,fd,RaidFd**));
DBUG_RETURN(raid->Seek(pos,whence,MyFlags));
}
else
DBUG_RETURN(my_seek(fd, pos, whence, MyFlags));


to

if (is_raid(fd))
{
assert(pos != MY_FILEPOS_ERROR);
RaidFd *raid= (*dynamic_element(&RaidFd::_raid_map,fd,RaidFd**));
DBUG_RETURN(raid->Seek(pos,whence,MyFlags));
}
else
DBUG_RETURN(my_seek(fd, pos, whence, MyFlags));


since it's seems to be only needed to test the pos in raid mode (moreover
the assert is inside the is_raid condition at other parts of the code).

Regards,
Jocelyn

----- Original Message -----
From: <lenz@xxxxxxxxx>
To: <internals@xxxxxxxxxxxxxxx>
Sent: Wednesday, April 30, 2003 11:44 AM
Subject: bk commit - mysqldoc tree (1.336)


> Below is the list of changes that have just been committed into a local
> mysqldoc repository of lenz. When lenz does a push these changes will
> be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://www.mysql.com/doc/I/n/Installing_source_tree.html
>
> ChangeSet
> 1.336 03/04/30 11:44:38 lenz@xxxxxxxxx +1 -0
> - Added 4.0.13 NEWS entry (removed MyISAM RAID support from Max
binaries)
>
> Docs/manual.texi
> 1.308 03/04/30 11:44:38 lenz@xxxxxxxxx +5 -0
> - Added 4.0.13 NEWS entry (removed MyISAM RAID support from Max
binaries)
>
> # This is a BitKeeper patch. What follows are the unified diffs for the
> # set of deltas contained in the patch. The rest of the patch, the part
> # that BitKeeper cares about, is below these diffs.
> # User: lenz
> # Host: kallisto.local
> # Root: /space/my/mysqldoc
>
> --- 1.307/Docs/manual.texi Wed Apr 30 10:47:43 2003
> +++ 1.308/Docs/manual.texi Wed Apr 30 11:44:38 2003
> @@ -57978,6 +57978,11 @@
> Functionality added or changed:
> @itemize
> @item
> +Disabled MyISAM RAID in the Max binary packages - several users reported
> +assertion failures even when not using RAID (bug #346). Some of its
> +functionality can be achieved by using @code{MERGE} tables instead.
> +@xref{MERGE, , @code{MERGE} tables}.
> +@item
> @code{CURRENT_USER()} and "access denied" error messages now report
hostname
> exactly as it was specified in the @code{GRANT} command.
> @item
>
> --
> MySQL Internals Mailing List
> For list archives: http://lists.mysql.com/internals
> To unsubscribe:
http://lists.mysql.com/internals?unsub=joc@xxxxxxxxxxxxxxx
>
>


--
MySQL Internals Mailing List
For list archives: http://lists.mysql.com/internals
To unsubscribe:
http://lists.mysql.com/internals?unsub=gcdmd-internals@xxxxxxxxxxx




<Prev in Thread] Current Thread [Next in Thread>
Google Custom Search

News | FAQ | advertise