bk commit into 4.0 tree (1.1480)

Below is the list of changes that have just been committed into a local
4.0 repository of monty. When monty does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://www.mysql.com/doc/I/n/Installing_source_tree.html

ChangeSet
  1.1480 03/04/28 12:31:19 monty@xxxxxxxxxxxxxxx +1 -0
  Better test for regular files.

  mysys/default.c
    1.25 03/04/28 12:31:17 monty@xxxxxxxxxxxxxxx +7 -2
    Better test for regular files.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User: monty
# Host: mashka.mysql.fi
# Root: /home/my/mysql-4.0

--- 1.24/mysys/default.c        Tue Apr 22 20:18:45 2003
+++ 1.25/mysys/default.c        Mon Apr 28 12:31:17 2003
@@ -249,8 +249,13 @@
     MY_STAT stat_info;
     if (!my_stat(name,&stat_info,MYF(0)))
       return 0;
-    /* ignore world-writeable _regular_ files */
-    if (stat_info.st_mode & S_IWOTH && stat_info.st_mode & S_IFREG)
+    /*
+      Ignore world-writable regular files.
+      This is mainly done to protect us to not read a file created by
+      the mysqld server, but the check is still valid in most context. 
+    */
+    if ((stat_info.st_mode & S_IWOTH) &&
+       (stat_info.st_mode & S_IFMT) == S_IFREG)
     {
       fprintf(stderr, "warning: World-writeable config file %s is ignored\n",
               name);

-- 
MySQL Internals Mailing List
For list archives: http://lists.mysql.com/internals
To unsubscribe:    
http://lists.mysql.com/internals?unsub=gcdmd-internals@xxxxxxxxxxx