Linus, please go back and read my message
again. It didn't suggest anything as ridiculous as you are trying to
imply (“Everybody working with ArgoUML must
have a Windows XP with Eclipse 3.2 and JDK1.4.2_07!” ).
The suggestion is that for only those
developers who are using Eclipse (all core developers?) and only if all those
developers have upgraded to Eclipse 3.2 (has anyone not upgraded yet?)
that we enable an Eclipse feature which requires developers to compile against
a Java 1.4 JRE (but any
1.4.*_* JRE that they desire). Do you really think that's overly
restrictive compared to the cost of requiring manual checks to catch broken
code which is checked in? In this case the cost included not only your
time and Thomas', but it also delayed a release.
I'm tempted at this point to launch into a
long rant about how every single process improvement suggestion or quality
improvement suggestion seems to get vetoed, but it's the weekend, so I'm going
to go enjoy myself instead!
-----Original Message-----
From: Linus Tolke
[mailto:linus.tolke@xxxxxxxx]
Sent: Thursday, November 02, 2006
4:23 PM
To: dev@xxxxxxxxxxxxxxxxxx
Subject: RE: [argouml-dev] Project
compiler settings (was The plan for the 0.23.3 release)
Well, yes of course this is a compromise
and as a compromise there are problems.
If we would decide that “Everybody
working with ArgoUML must have a Windows XP with Eclipse 3.2 and
JDK1.4.2_07!” we would probably alienate some developers. Likewise for
any similar statement.
I prefer to let everyone decide on their
own environment within the boundaries that we set up. Currently the boundaries
are JDK1.4.2 or later, any OS that has JDK1.4.2 and subversion.
The environment required by section 3.3 in
the cookbook is for ArgoUML as a product. We, the development team, shall have
processes and quality assurance set up to make sure that a user can run ArgoUML
using a JRE 1.4.2. I am sure we could do better but at least I am building the
releases with a JDK 1.4.2. Every developer that wants to contribute to this
specific quality assurance part can compile with JDK 1.4.2 as often as he likes
but we don’t require everyone to do so.
The level set by section 7.2 for checking
in things is lower than that. Even so there have been some examples where this
lower standard is not lived up to.
We also have the other “quality
metrics”. The checkstyle, findbugs, and jdepend setups. They are also
“available” but occasionally a developer commits code with new
checkstyle warnings or findbugs problems. This is acceptable.
We should work with helping each-other in
improving by fixing the problems introduced and enlighten the person that did
it.
/Linus
From: Tom Morris
[mailto:tfmorris@xxxxxxxxx]
Sent: den 1 november 2006 22:29
To: dev@xxxxxxxxxxxxxxxxxx
Subject: RE: [argouml-dev] Project
compiler settings (was The plan for the 0.23.3 release)
I don't understand why it's acceptable to
have a tool environment that allows people to check in broken code. It's
certainly not acceptable to me that I could compile in both our provided
development environments, run the full set of unit tests, and still check in
broken code.
When you say you don't want to "require all developers to always have also the java 1.4 environment
at hand" it was my understanding
that we already explicity require this. How else does one develop and
test for a Java 1.4 environment as required by section 3.3 of the
cookbook? Are we saying that the rationale for not checking in broken
code as outlined in section 7.2 no longer applies?
-----Original Message-----
From: Linus Tolke
[mailto:linus.tolke@xxxxxxxx]
Sent: Tuesday, October 31, 2006
5:01 PM
To: dev@xxxxxxxxxxxxxxxxxx
Subject: RE: [argouml-dev] Project
compiler settings (was The plan for the 0.23.3 release)
Hello Tom!
It was probably me that removed the java
1.4 libraries from the Eclipse environment. I had some problems with it and
didn’t understand why we explicitly specified the libraries.
I don’t think that this is a serious
problem. Not serious enough to require all developers to always have also the
java 1.4 environment at hand. I hope that having everyone running their
favorite version of JDK glancing at the nightly build, and some extra checks
before every release would be enough.
For me, as you understand from above, the
big problem is that the nightly build doesn’t give information that the
build failed at a glance. I will have to fix that.
/Linus
From: Tom Morris
[mailto:tfmorris@xxxxxxxxx]
Sent: den 31 oktober 2006 21:30
To: dev@xxxxxxxxxxxxxxxxxx
Subject: [argouml-dev] Project
compiler settings (was The plan for the 0.23.3 release)
I've fixed this problem, but the fact that
it occurred points out a shortcoming in both our Eclipse and Ant build
environments.
For Eclipse, we specify the compiler
versions, but not the Java libraries to compile against, so a change in
the developer's workspace settings will affect ArgoUML builds. I believe
I had library versions specified at some time in the Eclipse project settings, but
they got removed (not sure whether it was intentional or not). If
everyone has upgraded to Eclipse 3.2, I'd like to see us have all Eclipse
project definitions specify the J2SE-1.4 execution environment. There's a
little background about this new feature here http://www.developer.com/java/ent/article.php/3639021
For Ant, we rely on the libraries pointed
to by JAVA_HOME, so changes to this in the system environment can affect
ArgoUML builds. We don't set this explicitly, nor do we check to make
sure that it points to Java 1.4 libraries. Since I have multiple Java
development environments, I guess I'll just hardwire my build scripts to reset
JAVA_HOME to point to a Java 1.4 installation.
